Re: [PATCH 3/3] tools/nolibc: add support for hexagon

[Willy Tarreau]

Hi Thomas,

On Wed, Aug 19, 2026 at 08:31:53AM +0200, Thomas Weißschuh wrote:
> +++ b/tools/include/nolibc/arch-hexagon.h
> @@ -0,0 +1,164 @@
> +/* SPDX-License-Identifier: LGPL-2.1 OR MIT */
> +/*
> + * hexagon specific definitions for NOLIBC
> + * Copyright (C) 2026 Thomas Weißschuh <linux@xxxxxxxxxxxxxx>
> + */
> +
> +#ifndef _NOLIBC_ARCH_HEXAGON_H
> +#define _NOLIBC_ARCH_HEXAGON_H
> +
> +#include <linux/unistd.h>
> +
> +#include "compiler.h"
> +#include "crt.h"
> +
> +/*
> + * Syscalls for OpenRISC:
> + *   - syscall number is passed in r6
> + *   - arguments are in r0, r1, r2, r3, r4, r5
> + *   - the system call is performed by calling trap0(#1)
> + *   - syscall return value is in r0
> + */

I'm not familiar with hexagon, but the file is named hexagon and the
comment speaks about openrisc. Is this a leftover from a copy-paste,
or is there an untold relation between the two, that would then deserve
at least an extra line to explain to those who don't know when passing
by ?

Other than this detail, while I can't judge for the syscall instructions
for this arch, I'm fine with the rest of the patch and the series, so
feel free to add:

Acked-by: Willy Tarreau <w@xxxxxx>

Thanks,
Willy