Re: [PATCH v1 v1] ntfs: do not update ctime when setxattr fails
From: Hyunchul Lee
Date: Wed Aug 19 2026 - 03:33:53 EST
Hi Baolin,
2026년 8월 18일 (화) 오후 5:28, Baolin Liu <liubaolin12138@xxxxxxx>님이 작성:
>
> From: Baolin Liu <liubaolin@xxxxxxxxxx>
>
> ntfs_setxattr() updates ctime and marks the inode dirty even when
> the operation fails. A failed setxattr(2) must not change file
> metadata.
>
> Update ctime only on success.
>
> Fixes: fc053f05ca28 ("ntfs: add reparse and ea operations")
> Signed-off-by: Baolin Liu <liubaolin@xxxxxxxxxx>
Looks good to me.
Reviewed-by: Hyunchul Lee <hyc.lee@xxxxxxxxx>
--
Thanks,
Hyunchul