Re: [PATCH v2] staging: rtl8723bs: remove extern from function declarations in header files

[Dan Carpenter]

On Tue, Aug 18, 2026 at 08:50:55PM +0530, Dhanush Muralidharan wrote:
> Function declarations in header files are implicitly extern. Remove the redundant extern keyword to clean up the code.
> 
> Signed-off-by: Dhanush Muralidharan <dhanushmuralidharan@xxxxxxxxx>
> ---

1. Run your patch through checkpatch
2. Add a little note under the --- cut off to say what changed

https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

> -extern int rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr, struct pkt_attrib *pattrib);
> +s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr, struct pkt_attrib *pattrib);

3. Don't make unrelated changes like s/int/s32/
4. Also int is better than s32

regards,
dan carpenter