Re: [PATCH] net: starfire: fix ioaddr sign-extension causing ioremap() failure

[Simon Horman]

On Sat, Aug 15, 2026 at 01:24:32PM -0600, Ivy Lopez wrote:
> ioaddr is declared as a signed long, but is assigned the result of
> pci_resource_start(), which returns an unsigned resource_size_t.
> On configurations where the BAR address has its high bit set, the
> value sign-extends when passed to ioremap(), producing a bogus
> 64-bit address and causing device probe to fail:
> 
>   ioremap: invalid physical address fffffffffe480000
>   starfire 0000:08:04.0: cannot Remap 0x80000 @ 0xfe480000, aborting
> 
> Change ioaddr to unsigned long so pci_resource_start()'s value is
> preserved correctly.
> 
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=198035
> Signed-off-by: Ivy Lopez <skunkolee@xxxxxxxxx>
> 
> Signed-off-by: Ivy Lopez <skunkolee@xxxxxxxxx>

I guess this is a minor tooling mishap, but one Signed-off-by is enough.

> ---
>  drivers/net/ethernet/adaptec/starfire.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/adaptec/starfire.c b/drivers/net/ethernet/adaptec/starfire.c
> index f1109d90e1fc..b72b393e6fb2 100644
> --- a/drivers/net/ethernet/adaptec/starfire.c
> +++ b/drivers/net/ethernet/adaptec/starfire.c
> @@ -634,7 +634,7 @@ static int starfire_init_one(struct pci_dev *pdev,
>  	int i, irq, chip_idx = ent->driver_data;
>  	struct net_device *dev;
>  	u8 addr[ETH_ALEN];
> -	long ioaddr;
> +	unsigned long ioaddr;
>  	void __iomem *base;
>  	int drv_flags, io_size;
>  	int boguscnt;

I'm wondering if you considered using resource_size_t (and %pa[p]).
Given that is the both type returned by pci_resource_start() and
the type of the phys_addr parameter to ioremap().