Re: [PATCH v4 5/6] iio: dac: ad5504: strictly separate ACPI and DT probe paths

[Taha Ed-Dafili]

> #define AD5504_VA_ACPI_DEFAULT_mV	(60 * MILLI)
> What does VA stand for?

VA stands for Analog supply Voltage as far as I know, following Analog
Devices datasheet convention. Will rename to AD5504_VREF_ACPI_DEFAULT_mV
to make it self-explanatory in v5.

> It's better to use has_acpi_companion() or is_acpi_device_node().
> I prefer to see the latter as that one unifies the style of checking
> across the drivers and subsystems.

Will switch to is_acpi_device_node(dev_fwnode(dev)) in v5 and add
<linux/acpi.h> accordingly.

> This should be (MICRO / MILLI) instead of MILLI.

Will fix in v5.

Best Regards,
Taha Ed-Dafili