Re: [PATCH v1 1/2] dt-bindings: arm: qcom: Add Maili SoC compatible
From: Konrad Dybcio
Date: Wed Aug 19 2026 - 04:56:50 EST
On 8/19/26 9:02 AM, Yijie Yang wrote:
>
>
> On 8/19/2026 2:35 PM, Krzysztof Kozlowski wrote:
>> On 19/08/2026 08:28, Yijie Yang wrote:
[...]
>>>>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>>>>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>>>>> @@ -175,6 +175,9 @@ properties:
>>>>> - qcom,kaanapali-qrd
>>>>> - const: qcom,kaanapali
>>>>> + - items:
>>>>> + - const: qcom,maili
>>>>
>>>> Heh? This cannot go alone.
>>>
>>> Keep only the SoC compatible string and exclude the board for now, as
>>> the latter is not currently used.
>>> https://lore.kernel.org/all/20260622-brainy-rapid-tody-dd7c3a@quoll/
>>
>> No, read my message there - this should be rejected! I even wrote:
>>
>> "But if ever this commit is used in argument "oh, compatible without
>> user was accepted here by Krzysztof, so I can do the same", I will
>> simply NAK such future contribution without reading the rest."
>>
>> So NAK because you did not even bother to read what I already stated!
>
> In patch 2/2, pd-mapper serves as the user. Is there any other reason to reject this binding?
This defines/allows a top-level compatible of
compatible = "qcom,maili";
which is missing the board part, and that is strictly required.
Konrad