Re: [PATCH] iio: accel: sca3000: fix frequency divider condition check

[Joshua Crofts]

On Wed, 19 Aug 2026 12:41:01 +0100
Salah Triki <salah.triki@xxxxxxxxx> wrote:

> When setting the sampling frequency, the check for `base_freq / 2` is
> followed by an independent `if` statement for `base_freq / 4`. If `val`
> equals `base_freq / 2`, the second check fails and falls through to the
> `else if (val != base_freq)` branch, returning `-EINVAL` erroneously.
> 
> Fix this by chaining the checks with `else if`.
> 
> Signed-off-by: Salah Triki <salah.triki@xxxxxxxxx>
> ---

Good catch, this issue is 10 years old!

However, you're missing a fixes tag, I think b4 will pick it up
if I leave it here since I already ran git blame.

Fixes: e0f3fc9b47e6 ("iio: accel: sca3000_core: implemented IIO_CHAN_INFO_SAMP_FREQ")

+ cc stable

Reviewed-by: Joshua Crofts <joshua.crofts1@xxxxxxxxx>

-- 
Kind regards,
Joshua Crofts