Re: [PATCH v2 3/3] arm64: dts: qcom: monaco-evk: Describe the PCIe M.2 Key E connector

[Wei Deng]

Hi Konrad,

On Thu, 30 Jul 2026 19:27:59 +0200, Konrad Dybcio wrote:
> On 7/29/26 4:40 AM, Wei Deng wrote:
> > The monaco EVK has a PCIe M.2 Mechanical Key E connector to connect
> > wireless connectivity cards over PCIe and UART interfaces. Hence,
> > describe the connector node and link it with the PCIe 0 Root Port and
> > UART2 nodes through graph port/endpoint.
> > 
> > The M.2 Key E connector is powered by a 3.3V fixed regulator
> > (vreg_wcn_3p3) which is sourced from the board's 12V DC input rail
> > (vreg_dcin_12v). Both regulators are always-on and are required by the
> > pcie-m2-e-connector binding.
> > 
> > Also add the serial1 = &uart2 alias, which is required for the
> > Bluetooth serdev device to be enumerated on the UART2 interface.
> > 
> > The graph endpoint anchors (pcieport0_ep, uart2_ep) referenced here are
> > defined in monaco.dtsi (see "arm64: dts: qcom: monaco: Add graph
> > port/endpoint anchors to pcieport0 and uart2").
> > 
> > Signed-off-by: Wei Deng <wei.deng@xxxxxxxxxxxxxxxx>
> > ---
> 
> [...]
> 
> > +	vreg_dcin_12v: regulator-dcin-12v {
> > +		compatible = "regulator-fixed";
> > +
> > +		regulator-name = "VREG_DCIN_12V";
> > +		regulator-min-microvolt = <12000000>;
> > +		regulator-max-microvolt = <12000000>;
> > +
> > +		regulator-always-on;
> > +		regulator-boot-on;
> > +	};
> > +
> > +	vreg_wcn_3p3: regulator-wcn-3p3 {
> > +		compatible = "regulator-fixed";
> > +
> > +		regulator-name = "VREG_WCN_3P3";
> > +		regulator-min-microvolt = <3300000>;
> > +		regulator-max-microvolt = <3300000>;
> > +
> > +		vin-supply = <&vreg_dcin_12v>;
> 
> The 12v supply is not controllable, so we may drop it
> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>

Agreed, will drop vreg_dcin_12v and the vin-supply reference in v3.

Thanks for the review!

-- 
Best Regards,
Wei Deng