Re: [PATCH v4 13/15] rtc: rzn1: Add OF match data to gate SUBU register access

[Wolfram Sang]

> +	if (!scmp_val && !data->has_subu)
> +		return -EOPNOTSUPP;

I'd think here a helpful comment for the user is justified. Maybe "No
valid XTAL provided and SUBU mode not supported"?

> +static const struct rzn1_rtc_data rzn1_data = {
> +	.has_subu = true,
> +};

'rzn1_data' is maybe too generic? rzn1_rtc_rzn1_data? Yeah, looks a bit
weird but I personally still like it better.

Attachment: signature.asc
Description: PGP signature