Re: [PATCH v4 4/9] iio: dac: mcp47feb02: use dev_dbg for invalid label
From: Andy Shevchenko
Date: Wed Aug 19 2026 - 10:30:34 EST
On Wed, Aug 19, 2026 at 03:41:08PM +0300, Ariana Lazar wrote:
> Correct unneccesarry probe error returned at an invalid label with a debug
> message instead.
Why?!
...
> ret = fwnode_property_read_string(child, "label", &data->labels[reg]);
> if (ret)
> - return dev_err_probe(dev, ret, "%pfw: invalid label\n",
> - fwnode_get_name(child));
> + dev_dbg(dev, "%s: invalid label\n", fwnode_get_name(child));
My gosh, the patch before this one should really fix the fwnode_get_name()
usage here.
return dev_err_probe(dev, ret, "%pfw: invalid label\n", child);
Otherwise it's a good way to Oops.
I haven't checked the rest, but this is how it has to be when %pfw is used.
--
With Best Regards,
Andy Shevchenko