Re: [PATCH v2 13/13] x86/msr: Simplify some rdmsrq() use cases

[Sean Christopherson]

On Wed, Aug 19, 2026, Juergen Gross wrote:
> After the conversion of rdmsrq() to an inline function some use cases
> can be simplified by dropping an intermediate variable.

...

>  static inline void update_debugctlmsr(unsigned long debugctlmsr)
> diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
> index 2097602a00a0..2a68f937c080 100644
> --- a/arch/x86/include/asm/kvm_host.h
> +++ b/arch/x86/include/asm/kvm_host.h
> @@ -2415,10 +2415,7 @@ static inline void kvm_load_ldt(u16 sel)
>  #ifdef CONFIG_X86_64
>  static inline unsigned long read_msr(unsigned long msr)

NAK, please fold in "KVM: x86: Remove the KVM private read_msr() function"[*].
I very deliberately went out of my way to leave read_msr() as-is when moving code
out kvm_host.h, as I was expecting the MSR cleanups to eliminate it entirely.

[*] https://lore.kernel.org/all/20260218082133.400602-5-jgross@xxxxxxxx

>  {
> -	u64 value;
> -
> -	value = rdmsrq(msr);
> -	return value;
> +	return rdmsrq(msr);
>  }
>  #endif
>  
> -- 
> 2.55.0
>