Re: [PATCH net] net: macb: Move macb_{alloc,free}_tieoff() out of CONFIG_OF block

[Nathan Chancellor]

On Wed, Aug 19, 2026 at 03:10:32PM +0800, luoxuanqiang wrote:
> 在 2026/8/19 09:14, Nathan Chancellor 写道:
> > Commit 5262eab9462a ("net: macb: allocate tieoff descriptor once across
> > device lifetime") moved macb_alloc_tieoff() and macb_free_tieoff() into
> > a CONFIG_OF block, breaking the build when it is disabled:
> > 
> >    drivers/net/ethernet/cadence/macb_main.c: In function 'macb_probe':
> >    drivers/net/ethernet/cadence/macb_main.c:5951:15: error: implicit declaration of function 'macb_alloc_tieoff' [-Wimplicit-function-declaration]
> >     5951 |         err = macb_alloc_tieoff(bp);
> >          |               ^~~~~~~~~~~~~~~~~
> >    drivers/net/ethernet/cadence/macb_main.c:5973:9: error: implicit declaration of function 'macb_free_tieoff' [-Wimplicit-function-declaration]
> >     5973 |         macb_free_tieoff(bp);
> >          |         ^~~~~~~~~~~~~~~~
> > 
> > Moving macb_alloc_tieoff() from its original positive does not appear to
> 
> nit: s/from its original positive/from its original position/

Whoops, good catch! I can send a v2 later unless one of the maintainers
don't mind fixing that during application time. Thanks for taking a
look.

-- 
Cheers,
Nathan