Re: [PATCH v7 1/5] platform/x86: intel_lpss: add resource conflict quirk for Dell Latitude 5285

[Andy Shevchenko]

On Wed, Aug 19, 2026 at 04:01:03PM +0200, Thierry Chatard wrote:
> The Dell Latitude 5285 2-in-1 has a BIOS bug where the ACPI GEXP device
> and the I2C4 controller (INT3446) both claim the same MMIO region via the
> shared SB04 variable. This causes intel_lpss_acpi to fail binding to I2C4
> with -EBUSY, preventing the front camera (OV5670) sensor from being
> registered.
> 
> Add a DMI quirk that selects IGNORE_RESOURCE_CONFLICTS for INT3446 on this
> machine, matching the existing pattern used by other LPSS quirks.

You replied to the same thread as all previous versions: don't do like this.
The below seems doesn't follow comments from me given against v1, why?
With all this, please, go to the whole thread, read all comments, address them,
or reply why you disagree.

Also v8 requires a cover letter.

...

> +	if (acpi_dev_hid_uid_match(ACPI_COMPANION(&pdev->dev),
> +				   "INT3446", NULL) &&

This should be rather in the ACPI ID table, so the respective match function,
see how intel-lpss-pci.c organises quirks.

> +	    dmi_check_system(dell5285_lpss_dmi)) {
> +		dev_info(&pdev->dev, "Dell 5285: applying IGNORE_RESOURCE_CONFLICTS for I2C4\n");

No. Message has to be generic (and not here, but where quirk is really being
applied, in intel-lpss.c).

> +		data = &spt_i2c_info_ignore_conflicts;
> +	}

-- 
With Best Regards,
Andy Shevchenko