Re: [PATCH v4 0/9] KVM: TDX: Enable VM-DoS Prevention Features for TDX

[Sean Christopherson]

On Wed, Aug 19, 2026, Rick P Edgecombe wrote:
> On Wed, 2026-08-19 at 17:48 +0800, Xiaoyao Li wrote:
> > Patch 6 itself is a fix for VMX and is OK for cc stable though maybe not
> > necessary.  Patch 6 is added to this series since it can help stop Sashiko
> > repeating its finding of VMX's pre-existing issue, and it's also necessary
> > for patch 9 to consilidate the exit handler for VMX and TDX.
> 
> To me this is not a valid reason. Sashiko is great, but we can't let false
> positives drive the patches. Given that the series is so big now, I'd think it
> would be better to leave 6 and 9 for follow up, so we can focus on the core
> thing.

Hmm, I disagree.  If the consolidation weren't here, I'd absolutely ask for it.
This is new feature enabling.  Yeah, it happens to be tagged for stable, but at
the end of the day, it's new feature enabling.  And it's standard operation
procedure to do cleanups and dedup code as part of new feature enabling.

If anything patch 6 should be patch 1, but that's a minor detail I can sort out
when applying (assuming another version isn't required).