Re: [PATCH net-next v11] net: phy: Add driver for Motorcomm Quad 2.5GbE phy

[Kyle Switch]

On 8/18/26 09:13, Andrew Lunn wrote:
> > +	if (link) {
> > +		phydev->link = 1;
> > +		phydev->pause = !!(lpa & BIT(10));
> > +		phydev->asym_pause = !!(lpa & BIT(11));
> This is wrong.
>
> Where do you see any other driver doing this?
>
> phy_resolve_aneg_pause() will set phydev->pause and
> phydev->asym_pause.
>
> You should be trying to use genphy_read_status() to do most of the
> work, and then mix in the 2.5G status information afterwards.

Ans: will be fixed in v12. The acquisition and synchronization

        of link status will adopt a more common approach.

>      Andrew