Re: [PATCH treewide 4/5] iio: frequency: adf4377: Make sure clk_init_data is fully initialized

From: Jonathan Cameron

Date: Wed Aug 19 2026 - 21:38:23 EST


On Wed, 19 Aug 2026 17:22:41 -0400
Brian Masney <bmasney@xxxxxxxxxx> wrote:

> On Wed, Aug 19, 2026 at 09:05:18PM +0200, Geert Uytterhoeven wrote:
> > The clk_init_data structure contains several mutually-exclusive members
> > for different methods to specify the possible parents of a clock,
> > prompting drivers to initialize only the members they need. However,
> > not initializing all members may cause subtle issues, which are only
> > exposed when CONFIG_INIT_STACK_ALL_PATTERN or CONFIG_INIT_STACK_NONE is
> > enabled.
> >
> > adf4377_clk_register() fills in init.parent_data, and assumes that
> > init.parent_names is NULL. However, the latter in uninitialized, and
> > thus may cause a crash.
> >
> > Make sure all members are fully initialized, to fix such bugs, and to
> > avoid future breakage when converting drivers to a different method for
> > specifying the parents.
> >
> > Fixes: 60e5448ddbec2dc2 ("iio: frequency: adf4377: add clk provider support")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>
> Reviewed-by: Brian Masney <bmasney@xxxxxxxxxx>
>

Applied to the fixes-togreg branch of iio.git
I'll rebase on rc1 before sending a pull request (so waiting for that
to be available)

Thanks,

Jonathan