Re: [PATCH 09/27] gpu: nova-core: add build ID headers to debugfs log buffer dumps
From: John Hubbard
Date: Wed Aug 19 2026 - 22:04:18 EST
On 8/19/26 6:30 PM, Timur Tabi wrote:
> On Wed, 2026-08-19 at 18:00 -0700, John Hubbard wrote:
>>> I'm assuming you want me to change that back? I didn't realize the build ID was actually
>>> going
>>> to be used by the driver.
>>
>> Well, let's do whatever is best. If you really want/need BLID to be 64 bytes
>> then I can update this series to match.
>
> You would need to run some ascii_to_hex command on the string to turn it back to 32 bytes, which
> is silly. I made it 64 bytes because I thought the only use case for it was to display it.
OK, yes, please change it back, then. Having BLID here is of course
incredibly convenient, because we can avoid all kinds of difficulty
in decoding the logs. The decoder really prefers having this, and
then it does the right thing.
I've tested log decoding with this series and it is working nicely,
btw.
thanks,
--
John Hubbard