Re: [PATCH v3] auxdisplay: arm-charlcd: Use DEFINE_SIMPLE_DEV_PM_OPS for power management

[Uwe Kleine-König]

hello,

On Thu, Aug 20, 2026 at 09:38:26AM +0800, Li Jun wrote:
> Replace the manually defined dev_pm_ops structure with the
> DEFINE_SIMPLE_DEV_PM_OPS macro to simplify the power management code.
> This macro automatically handles CONFIG_PM_SLEEP configuration
> and generates freeze/thaw/poweroff/restore callbacks, reducing
> boilerplate code.
> 
> Changes:
> -Replace SIMPLE-DEV-PM-OPS() in v1 v2 with DEFINE_SIMPLE_deV_PM-OPS() for pm.

It only matters a little, but it's DEFINE_SIMPLE_DEV_PM_OPS().

> -Corrected grammar errors in v1 comment.

The description of changes between different revisions of the seris
should be located after the tripple-dash below to not let it go into git
when applied.

I fail to see what changed for v3, the changelog seems to match that of
v2. Also there is already a v4 before you got any feedback for v3, even
before someone had a chance to give feedback. Maintainer-Opinions differ
about the minimal interval between revisions, but three submissions
within a day is too much for any maintainer I think.

Additionally Andy requested the use of pm_sleep_ptr() which isn't even
in v4.

I think the same is needed for your firmware/arm_scmi patch and also for
the bluetooth one.

The usage of DEFINE_SIMPLE_DEV_PM_OPS() is an improvement, but now you
have (at least) three series in flight and the trivial feedback you
received here applies to all three. As someone who also sends many
patches, I recommend to get up to speed slowly. Work on a single patch
first, and only once you get that in---or at least positive feedback on
it---address one or two further drivers. When you have a handful of
patches in, you can speed up. But as it is now, you only occupy many
people finding the same issues in your patches. :-\

Best regards
Uwe

Attachment: signature.asc
Description: PGP signature