Re: [PATCH v1 1/2] ASoC: tac5xx2-sdw: update default regmap registers

[Holalu Yogendra, Niranjan]

> On 19:17-20260819, Mark Brown wrote:
> Subject: Re: [PATCH v1 1/2] ASoC: tac5xx2-sdw: update default regmap registers
>
> > On Wed, Aug 19, 2026 at 11:04:26AM +0530, Niranjan H Y wrote:
> 
> > -	REG_SEQ0(SDW_SDCA_CTL(TAC_FUNCTION_ID_SA, TAC_SDCA_ENT_FU23,
> > -			      TAC_SDCA_CHANNEL_GAIN, TAC_CHANNEL_LEFT), 0),
> > -	REG_SEQ0(SDW_SDCA_CTL(TAC_FUNCTION_ID_SA, TAC_SDCA_ENT_FU23,
> > -			      TAC_SDCA_CHANNEL_GAIN,  TAC_CHANNEL_RIGHT), 0),
> 
> The new macros use _CHANEL_VOLUME and _MASTER_GAIN, there's none using _CHANNEL_GAIN?

This was intentional to drop CHANNEL_GAIN as it is found to be not required for FU23.

I think I will add cleaner fix in next patch. What we need really are
#define TAC_SDCA_MASTER_GAIN	0x0B ( should be probably renamed to *_CHANNEL_GAIN )
#define TAC_SDCA_CHANNEL_VOLUME	0x02

And need to drop the duplicate macro 
#define TAC_SDCA_CHANNEL_GAIN	0x02

Regards
Niranjan