Re: [PATCH 01/10] dt-bindings: pinctrl: qcom,tlmm-common: allow functions on the HSIC pins

From: Krzysztof Kozlowski

Date: Thu Aug 20 2026 - 02:38:20 EST


On Mon, Aug 10, 2026 at 06:42:05PM +0300, Dmitry Baryshkov wrote:
> The common TLMM state schema requires the function property for GPIO
> pins and forbids it for all special pins. That rule is wrong for the
> MSM8974 HSIC pads: unlike the SDC pads, hsic_data and hsic_strobe are
> muxable pin groups (between the gpio and hsic_ctl functions, see
> HSIC_PINGROUP in pinctrl-msm8x74.c), and the msm8974 schema already
> lists hsic_ctl in its function enum. As a result any valid HSIC
> pinctrl state fails validation.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>

Best regards,
Krzysztof