Re: [PATCH 3/6] ASoC: cs48l32: use str_lock_unlock() helper

[Andy Shevchenko]

On Thu, Aug 20, 2026 at 09:11:10AM +0300, Dmitry Antipov wrote:
> In 'cs48l32_wait_for_fll()', prefer 'str_lock_unlock()' choice
> helper over hardcoded strings.

...

>  #include <linux/property.h>
>  #include <linux/regmap.h>
>  #include <linux/regulator/consumer.h>
> +#include <linux/string_choices.h>
>  #include <linux/slab.h>
>  #include <linux/spi/spi.h>
>  #include <linux/string_choices.h>

If you keep in order you will see that this is already there :-)

...

> -	cs48l32_fll_warn(fll, "Timed out waiting for %s\n", requested ? "lock" : "unlock");
> +	cs48l32_fll_warn(fll, "Timed out waiting for %s\n",
> +			 str_lock_unlock(requested));

I would leave it on the single line, it will be shorter anyway than
the original code.

...

You need a cover letter and explain there how to merge. I believe the idea is
to merge it via Kees' string/hardening tree.

-- 
With Best Regards,
Andy Shevchenko