Re: [PATCH 4/6] ice: use string choice helpers

[Andy Shevchenko]

On Thu, Aug 20, 2026 at 09:11:11AM +0300, Dmitry Antipov wrote:
> Prefer 'str_locked_unlocked()', 'str_on_off()' and 'str_true_false()'
> string choice helpers over hardcoded strings where appropriate.

...

> +++ b/drivers/net/ethernet/intel/ice/ice.h
> @@ -35,6 +35,7 @@
>  #include <linux/linkmode.h>
>  #include <linux/bpf.h>
>  #include <linux/btf.h>
> +#include <linux/string_choices.h>
>  #include <linux/auxiliary_bus.h>
>  #include <linux/avf/virtchnl.h>
>  #include <linux/cpu_rmap.h>

This is a mess. I think they have to think (start thinking) about IWYU
principle. So, please add this include to the each file you touch with
this patch. Left the rest to the ICE developers to amend.

With that being done,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>

-- 
With Best Regards,
Andy Shevchenko