Re: [PATCH 6/6] net: sfc: use string choice helpers

[Andy Shevchenko]

On Thu, Aug 20, 2026 at 09:11:13AM +0300, Dmitry Antipov wrote:
> Prefer 'str_failed_passed()' and 'str_off_on()' choice helpers
> over hardcoded strings where appropriate.

...

>  	netif_info(efx, drv, efx->net_dev, "%s %sline self-tests\n",
> -		   rc == 0 ? "passed" : "failed",
> -		   (test->flags & ETH_TEST_FL_OFFLINE) ? "off" : "on");
> +		   str_failed_passed(rc),
> +		   str_off_on(test->flags & ETH_TEST_FL_OFFLINE));

This should be str_offline_online(). So, either add those, or drop misleading
str_off_on() in this patch.

...

Same for all cases in this patch.

-- 
With Best Regards,
Andy Shevchenko