Re: [PATCH 04/16] irqchip/crossbar: fix allocation and init cleanup

From: Thomas Gleixner

Date: Thu Aug 20 2026 - 02:55:07 EST


On Tue, Jul 14 2026 at 21:24, Haofeng Li wrote:
> From: Haofeng Li <lihaofeng@xxxxxxxxxx>
>
> crossbar_domain_alloc() returns in the middle of a multi-IRQ

Please write out 'interrupts'. This is a technical document and not a
SMS service.

> allocation without freeing IRQs and crossbar slots allocated by
> earlier iterations.
>
> If irq_domain_create_hierarchy() fails after crossbar_of_init(), the
> global crossbar object and its maps and MMIO mapping are also leaked.
>
> Roll back prior IRQs through crossbar_domain_free(), and release all
> crossbar resources when domain creation fails.
>
> Fixes: 783d31863fb8 ("irqchip: crossbar: Convert dra7 crossbar to stacked domains")
>

Stray newline.

> Signed-off-by: Haofeng Li <lihaofeng@xxxxxxxxxx>

Thanks,

tglx