Re: [PATCH] selftests/cgroup: Fix cg_run_in_subcgroups ignoring arg parameter

[Michal Koutný]

On Thu, Aug 20, 2026 at 03:09:44PM +0800, Hongfu Li <hongfu.li@xxxxxxxxx> wrote:
> From: Hongfu Li <lihongfu@xxxxxxxxxx>
> 
> cg_run_in_subcgroups() discards its arg and always passes NULL to cg_run(),
> turning the (void *)100 from test_kmem_dead_cgroups() into NULL so no
> allocation occurs.
> 
> This makes test_kmem_dead_cgroups() falsely pass without exercising the
> "dying cgroup with charged slab" scenario it intends to test.
> 
> Pass the arg through to cg_run() to fix this.
> 
> Fixes: 933dc80ec262 ("kselftests: cgroup: add kernel memory accounting tests")
> Signed-off-by: Hongfu Li <lihongfu@xxxxxxxxxx>
> ---
>  tools/testing/selftests/cgroup/test_kmem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Good catch,

Reviewed-by: Michal Koutný <mkoutny@xxxxxxxx>

Attachment: signature.asc
Description: PGP signature