Re: [PATCH v3 2/3] net: xilinx: axienet: Handle optional IRQ return value correctly

From: Paolo Abeni

Date: Thu Aug 20 2026 - 05:51:24 EST


On 8/18/26 8:39 AM, Pandey, Radhey Shyam wrote:
> On 8/17/2026 4:22 PM, phucduc.bui@xxxxxxxxx wrote:
>> From: bui duc phuc <phucduc.bui@xxxxxxxxx>
>>
>> lp->eth_irq is assigned from platform_get_irq_optional(), which returns
>> a non-zero interrupt number on success or a negative error number on
>> failure. Errors other than -ENXIO are handled before this check,
>> so -ENXIO is the only error value that can reach this point.
>>
>> Check for a negative value instead of treating 0 as an undefined IRQ.
>>
>> Signed-off-by: bui duc phuc <phucduc.bui@xxxxxxxxx>
>
> Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@xxxxxxx>
> Thanks!
IMHO even this one is 'net' material deserving a fixes tag.

@bui: please re-submit the whole series targeting the proper tree and
including the needed tags. Be sure to read and understand the relevant
documentation including:

Documentation/process/maintainer-netdev.rst

before submitting the next revision.

/P