Re: [PATCH v2 3/7] arm64: dts: qcom: Add Motorola One

[Konrad Dybcio]

On 8/20/26 11:42 AM, Adam Skladowski wrote:
> Add a devicetree for the Motorola One smartphone, which is based
> on the Jacala/MSM8953 SoC.
> 
> Supported functionality as of this initial submission:
> * I2C peripherals (Touchscreen,NFC)
> * Power Button, Volume Keys
> * Regulators (PM8953)
> * Remoteprocs (ADSP, MPSS, WCNSS)
> * USB
> 
> Device tree also contains supply maps to other subsystems like MDSS
> but due to missing dependencies like panel those are disabled.
> 
> Signed-off-by: Adam Skladowski <a39.skl@xxxxxxxxx>
> ---



[...]

> +	typec-portc@22 {
> +		compatible = "fcs,fusb302";
> +		reg = <0x22>;
> +		interrupts-extended = <&tlmm 9 IRQ_TYPE_LEVEL_LOW>;
> +
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&fusb302_int_default>;

nit: outlying sort


> +
> +		usb-role-switch = <&usb3>;
> +		vbus-supply = <&fusb302_vbus>;
> +
> +		connector {
> +			compatible = "usb-c-connector";
> +			label = "USB-C";
> +			power-role = "dual";
> +			data-role = "dual";
> +			try-power-role = "sink";
> +			typec-power-opmode = "default";
> +			source-pdos = <PDO_FIXED(5000, 500,
> +						 PDO_FIXED_DUAL_ROLE |
> +						 PDO_FIXED_DATA_SWAP |
> +						 PDO_FIXED_USB_COMM)>;
> +			sink-pdos = <PDO_FIXED(5000, 3000,
> +					       PDO_FIXED_DUAL_ROLE |
> +					       PDO_FIXED_DATA_SWAP |
> +					       PDO_FIXED_USB_COMM)>;
> +			op-sink-microwatt = <2000000>;

This is inconsistent with the sink-PDOs you defined (5 V 3 A vs 2 W)

Konrad