Re: [PATCH] HID: intel-thc-hid: intel-quicki2c: fix autosuspend cleanup during teardown

[Johan Hovold]

Hi Jiri,

On Thu, Aug 20, 2026 at 01:33:16PM +0200, Jiri Kosina wrote:
> On Tue, 18 Aug 2026, Johan Hovold wrote:
> 
> > > quicki2c_probe() calls pm_runtime_use_autosuspend(), but
> > > quicki2c_remove() does not call the matching
> > > pm_runtime_dont_use_autosuspend() during teardown.
> > > 
> > > If the autosuspend delay is set to a negative value while autosuspend
> > > is enabled, the runtime PM core increments usage_count to prevent
> > > runtime suspend. Without calling pm_runtime_dont_use_autosuspend()
> > > during teardown, this reference is not dropped.
> > 
> > I see that the HID ones have already been merged, but for the record:
> > 
> > As I've explained elsewhere, this is just misleading. There is no usage
> > count leak here as the count is balanced whenever the user re-enables
> > autosuspend through sysfs (by writing a non-negative timeout).
> > 
> > Drivers should clean up after themselves and disable autosuspend, but
> > this is more of a clean up than a fix and should not be backported.

> Looking at this now again in more detail, I believe the code change is 
> actually OK, but the changelog is misleading. Or am I missing something?

Indeed, the change itself is fine, but the commit message is misleading
and these do not need to be backported.

Johan