Re: [PATCH] efi: Make EFI_VARS_PSTORE depend on EFIVAR_FS

[Ard Biesheuvel]

On Thu, 23 Jul 2026, at 09:39, Ard Biesheuvel wrote:
> On Thu, 25 Jun 2026, at 19:12, Theodore Tucker wrote:
>> The efivars backend to pstore will not register if the efivarfs is
>> not available. The efivars sysfs interface was removed in Linux 6.0,
>> meaning efivarfs is now the only way pstore can write into EFI
>> variables. Making the dependency on the efivarfs explicit removes
>> a stumbling block when configuring a kernel with pstore.
>>
>> Signed-off-by: Theodore Tucker <theodore@xxxxxxxx>
>> ---
>>  drivers/firmware/efi/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>
> Applied, thanks.
>

Actually, EFI pstore does not depend on efivarfs, it only depends on
the efivars layer.

Why do you think it needs to depend on EFIVAR_FS?

>> diff --git a/drivers/firmware/efi/Kconfig b/drivers/firmware/efi/Kconfig
>> index 29e0729299f5..8dfd21e7a8e4 100644
>> --- a/drivers/firmware/efi/Kconfig
>> +++ b/drivers/firmware/efi/Kconfig
>> @@ -9,7 +9,7 @@ config EFI_ESRT
>> 
>>  config EFI_VARS_PSTORE
>>  	tristate "Register efivars backend for pstore"
>> -	depends on PSTORE
>> +	depends on PSTORE && EFIVAR_FS
>>  	select UCS2_STRING
>>  	default y
>>  	help
>> -- 
>> 2.47.3