Re: [PATCH 1/2] net: fec: Propagate PTP initialization errors

From: Paolo Abeni

Date: Thu Aug 20 2026 - 09:29:40 EST


On 8/20/26 1:14 PM, phucduc.bui@xxxxxxxxx wrote:
> From: bui duc phuc <phucduc.bui@xxxxxxxxx>
>
> Change fec_ptp_init() to return an error code instead of silently
> ignoring failures during PTP initialization.
>
> The PPS IRQ is not required for the FEC/PTP functionality, so its
> absence should not make the probe fail. However, an unavailable
> optional IRQ should be distinguished from an actual error returned
> during the IRQ lookup.
>
> If a platform does not support the PPS IRQ, it can omit the IRQ from
> its device tree and the optional lookup will return -ENXIO. Propagate
> other errors from the IRQ lookup instead of silently ignoring them.
>
> Also propagate failures from devm_request_irq() and ptp_clock_register().
>
> Update the function declaration in fec.h accordingly.
>
> Found by manual code inspection.
>
> Signed-off-by: bui duc phuc <phucduc.bui@xxxxxxxxx>
## Form letter - net-next-closed

We have already submitted our pull request with net-next material for v7.3,
and therefore net-next is closed for new drivers, features, code refactoring
and optimizations. We are currently accepting bug fixes only.

Please repost when net-next reopens after Aug 31st.

RFC patches sent for review only are obviously welcome at any time.

See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#development-cycle