Re: [PATCH v2 1/4] soc: qcom: geni-se: Fix endian conversion for serial_protocol comparison

[Konrad Dybcio]

On 8/20/26 4:30 PM, Viken Dadhaniya wrote:
> serial_protocol is declared as __le16 in struct se_fw_hdr, but was
> decoded with le32_to_cpu(). On big-endian systems the extra byte swap
> causes the field to always compare unequal to the protocol argument,
> so no firmware segment is ever selected.
> 
> Use le16_to_cpu() to match the field width.
> 
> Fixes: d4bf06592ad6 ("soc: qcom: geni-se: Add support to load QUP SE Firmware via Linux subsystem")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Viken Dadhaniya <viken.dadhaniya@xxxxxxxxxxxxxxxx>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>

Konrad