Re: [PATCH net v3] net/sched: sch_cake: fix autorate reconfiguration throttling

From: Toke Høiland-Jørgensen

Date: Thu Aug 20 2026 - 12:16:46 EST


Giuseppe Piscitelli <ooonea@xxxxxxxxx> writes:

> CAKE's autorate-ingress path intends to limit shaper reconfiguration to
> once per 250 ms, but last_reconfig_time is only checked and never updated.
> Since the field stays zero, every qualifying capacity-estimate window can
> call cake_reconfigure(), causing avoidable rate churn and scheduler work
> under bursty traffic.
>
> Store the current timestamp when autorate actually reconfigures the qdisc
> so the guard enforces the intended interval.
>
> Fixes: 7298de9cd725 ("sch_cake: Add ingress mode")
> Assisted-by: Codex:gpt-5.5
> Signed-off-by: Giuseppe Piscitelli <ooonea@xxxxxxxxx>

Please retain ACKs when reposting.

Acked-by: Toke Høiland-Jørgensen <toke@xxxxxxx>