[PATCH] staging: rtl8723bs: reorder conditions to avoid else branch

From: myeonghyeon.park

Date: Thu Aug 20 2026 - 12:26:54 EST


Fix the checkpatch.pl warning:

"WARNING: else is not generally useful after a break or return"

in core/rtw_recv.c.

Return early when the SN_EQUAL() condition is met and break when
SN_LESS() condition is false to eliminate the unnecessary else branch.

Signed-off-by: myeonghyeon.park <myeonghyeon.park@xxxxxxxxx>
---
drivers/staging/rtl8723bs/core/rtw_recv.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
index 7568fc514d7c..5776d0212ab8 100644
--- a/drivers/staging/rtl8723bs/core/rtw_recv.c
+++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
@@ -1782,14 +1782,15 @@ static int enqueue_reorder_recvframe(struct recv_reorder_ctrl *preorder_ctrl, un
pnextrframe = (union recv_frame *)plist;
pnextattrib = &pnextrframe->u.hdr.attrib;

- if (SN_LESS(pnextattrib->seq_num, pattrib->seq_num))
- plist = get_next(plist);
- else if (SN_EQUAL(pnextattrib->seq_num, pattrib->seq_num))
+ if (SN_EQUAL(pnextattrib->seq_num, pattrib->seq_num))
/* Duplicate entry is found!! Do not insert current entry. */
/* spin_unlock_irqrestore(&ppending_recvframe_queue->lock, irql); */
return false;
- else
+
+ if (!SN_LESS(pnextattrib->seq_num, pattrib->seq_num))
break;
+
+ plist = get_next(plist);
}

/* spin_lock_irqsave(&ppending_recvframe_queue->lock, irql); */
--
2.52.0