Re: [PATCH v6 2/3] media: qcom: jpeg: Add Qualcomm JPEG V4L2 encoder

[Dmitry Baryshkov]

On Thu, Aug 20, 2026 at 09:38:16PM +0300, Atanas Filipov wrote:
> On 7/30/2026 6:57 PM, Dmitry Baryshkov wrote:
> > On Thu, Jul 30, 2026 at 06:05:23PM +0300, Atanas Filipov wrote:
> > > Add a Qualcomm JPEG encoder driver implemented on top of the
> > > V4L2 mem2mem framework.
> > > 
> > > The driver wires vb2 queue handling, format negotiation, JPEG header
> > > handling, interrupt-driven job completion, and runtime PM/clock/ICC
> > > integration for the standalone JPEG encode hardware block.
> > > 
> > > This series targets SM8250 (Kona) platforms.
> > > 
> > > Signed-off-by: Atanas Filipov <atanas.filipov@xxxxxxxxxxxxxxxx>
> > > ---
> > 
> > > +
> > > +#define JPEG_V420_HW_CAP_DOWNSCALE_POS 8
> > > +#define JPEG_V420_HW_CAP_DOWNSCALE_MSK \
> > > +	(0x7u << JPEG_V420_HW_CAP_DOWNSCALE_POS)
> > > +
> > > +#define JPEG_V420_RST_CMD_FE_RESET_MSK			BIT_U32(0)
> > 
> > What is wrong with the standard BIT()?
> > 
> 
> What's wrong with standart BIT_U32() when dealing with 32-bit registers? Or
> do you simply like requesting meaningless changes?!

It's called uniformity. Most of the code in the kernel uses BIT() rather
than BIT_U32() to define values even for u32 registers.


-- 
With best wishes
Dmitry