Re: [PATCH v6 0/2] iio: adc: Add support for Texas Instruments ADS112C04

[Jonathan Cameron]

On Thu, 20 Aug 2026 15:51:50 +0800
Kyle Hsieh <kylehsieh1995@xxxxxxxxx> wrote:

> This patch series introduces support for the Texas Instruments ADS112C04
> Analog-to-Digital Converters.
> 
> The ADS112C04 (16-bit) is precision, low-power, delta-sigma ADCs with
> an I2C interface. They feature a flexible input multiplexer supporting
> single-ended and differential measurements, a programmable gain amplifier,
> and an internal voltage reference.
> 
> Note: While this chip shares similarities with the ADS112C14 (currently 
> being upstreamed by David Lechner), the register maps and feature sets 
> are sufficiently different to warrant a separate driver. However, the
> DT bindings and channel parsing logic have been aligned with the
> ADS112C14 conventions.
> 
> This initial submission provides a minimal feature set (single-shot 
> conversions and basic DRDY interrupt) covering current use cases.
> 
> Signed-off-by: Kyle Hsieh <kylehsieh1995@xxxxxxxxx>

Sashiko had some feedback on the interrupt - if you are respinning for
other reasons it might be good to add a comment in the dt-binding about
it being an edge interrupt. From a quick look at the datasheet a level
interrupt would not make much sense.

https://sashiko.dev/#/patchset/20260820-ti-ads112c04-driver-v6-0-0e8f0aacce9b%40gmail.com

Other than that, looks good to me.  You've had a lot of review from
others though so I'll leave it on list for a little while in case
any one wants to take a final look and perhaps give tags.

Thanks,

Jonathan