Re: [PATCH] bnxt_en: Fix call to hardware monitoring event handler
From: Kalesh Anakkur Purayil
Date: Fri Aug 21 2026 - 01:12:53 EST
On Fri, Aug 21, 2026 at 10:15 AM Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
>
> The first parameter of hwmon_notify_event() is supposed to be the hardware
> monitoring device. The bnxt driver calls it with the platform device as
> first parameter instead. This API break results in undefined behavior and
> may result in a crash.
>
> Pass the hardware monitoring device as parameter instead to fix the
> problem.
>
> Fixes: a19b4801457b0 ("bnxt_en: Event handler for Thermal event")
> Cc: Kalesh AP <kalesh-anakkur.purayil@xxxxxxxxxxxx>
> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
Thank you for the fix, LGTM!
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@xxxxxxxxxxxx>
--
Regards,
Kalesh AP
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature