Re: [PATCH v2 2/2] hwmon: (starfive-fan-tach) Add fan tach driver for StarFive JHB100

[Changhuang Liang]

Hi, Guenter

Thanks for the review.

> On 8/20/26 18:06, Changhuang Liang wrote:
> ...
> 
> >> So how long does it take to execute the "sensors" command with 16
> >> active fans ?
> >
> > # time sensors
> > starfive_fan_tach-isa-0000
> > Adapter: ISA adapter
> > fan1:           FAULT  (min =  300 RPM)
> > fan2:           FAULT  (min =  300 RPM)
> > fan3:           FAULT  (min =  300 RPM)
> > fan4:           FAULT  (min =  300 RPM)
> > fan5:           FAULT  (min =  300 RPM)
> > fan6:           FAULT  (min =  300 RPM)
> > fan7:           FAULT  (min =  300 RPM)
> > fan8:           FAULT  (min =  300 RPM)
> > fan9:           FAULT  (min =  300 RPM)
> > fan10:          FAULT  (min =  300 RPM)
> > fan11:          FAULT  (min =  300 RPM)
> > fan12:          FAULT  (min =  300 RPM)
> > fan13:          FAULT  (min =  300 RPM)
> > fan14:          FAULT  (min =  300 RPM)
> > fan15:          FAULT  (min =  300 RPM)
> > fan16:       1800 RPM  (min =  300 RPM)
> >
> >
> > real    0m4.865s
> > user    0m0.023s
> > sys     0m0.001s
> >
> 
> Normally I would say this is a no-go, but this is your chip (and, as we say, your
> funeral). Just please document that reading the fan status will take forever for
> disconnected fans.

Okay, I'll proceed with this solution for the time being, and I can revisit it later
to explore possible improvements. I will also record the current status in the 
documentation

Best Regards,
Changhuang