Re: [PATCH] i2c: at91: fix autosuspend cleanup during teardown

[Andi Shyti]

On Thu, Aug 20, 2026 at 04:50:13PM +0200, Krzysztof Kozlowski wrote:
> On 08/08/2026 17:26, Guangshuo Li wrote:
> > at91_twi_probe() calls pm_runtime_use_autosuspend(), but neither the
> > probe error path nor at91_twi_remove() calls the matching
> > pm_runtime_dont_use_autosuspend() during teardown.
> > 
> > If the autosuspend delay is set to a negative value while autosuspend
> > is enabled, the runtime PM core increments usage_count to prevent
> > runtime suspend. Without calling pm_runtime_dont_use_autosuspend()
> > during teardown, this reference is not dropped.
> > 
> > The documentation for pm_runtime_use_autosuspend() also notes that it
> > is important to undo it with pm_runtime_dont_use_autosuspend() at
> > driver exit time, unless runtime PM was initially enabled with
> > devm_pm_runtime_enable().
> > 
> > Add the missing pm_runtime_dont_use_autosuspend() calls to the probe
> > error and driver remove paths.
> > 
> > This issue was found by manual code inspection.
> > 
> > Fixes: d64a818859af ("i2c: at91: add support for runtime PM")
> > Cc: stable@xxxxxxxxxxxxxxx
> > Signed-off-by: Guangshuo Li <lgs201920130244@xxxxxxxxx>
> 
> How many separate I2C, drm, crypto, hwrng etc patches you sent?
> 
> You sent vast amount of patches, all separate, making it very difficult
> to track and respond in efficient way. Do not do that.
> 
> Group your work per subsystem.
> 
> You were asked to clarify and respond to incorrect fixes statement. I do
> not see how you clarified and responded at all.

Is this a kind of LLM command or what?

I'm going to check only the patches that have been acked and/or
reviewed (people have spent time for that), for the rest, please,
follow Krzysztof's direction, put them all together (or ask your
AI to do it) and resend.

Thanks,
Andi