Re: [PATCH] sh: remove unused setup_profiling_timer function
From: Anthony Iliopoulos
Date: Fri Aug 21 2026 - 06:06:43 EST
On Thu, Aug 20, 2026 at 04:00:37PM +0200, John Paul Adrian Glaubitz wrote:
> Hi Anthony,
>
> On Thu, 2026-08-20 at 14:39 +0200, Anthony Iliopoulos wrote:
> > setup_profiling_timer() is not used by any code at this point. Since a
> > default weak implementation exists, there is no need to keep this
> > arch-specific definition around. Remove it along with the now-redundant
> > profile header includes.
>
> Do you have any clue why it was still implemented for LoongArch which is
> a rather new architecture? I'm also seeing that it's not used anywhere,
> I'm just wondering why it was not removed before and why it was even
> included when LoongArch was added.
Its addition to LoongArch [1] slightly predates converting it to a weak
function [2], so up until that point all archs had to include the stub.
Regards,
Anthony
[1] 46859ac8af52 ("LoongArch: Add multi-processor (SMP) support")
[2] 787dbea11a5d ("profile: setup_profiling_timer() is moslty not implemented")