Re: [PATCH v6 2/2] iio: adc: ti-ads112c04: Add support for TI ADS112C04

[Andy Shevchenko]

On Thu, Aug 20, 2026 at 03:51:52PM +0800, Kyle Hsieh wrote:
> Add IIO driver support for the Texas Instruments ADS112C04 (16-bit)
> delta-sigma ADCs.
> 
> The driver implements:
> - Single-shot conversions using the IIO raw read interface.
> - Dynamic parsing of single-ended and differential channels from
>   device tree child nodes.
> - Hardware interrupt support via the DRDY pin, falling back to
>   software polling if no IRQ is provided.
> - Per-channel reference source selection (internal 2.048V, external
>   REFP/REFN, or AVDD) via the reference-sources device tree property.
>   refn-supply is not yet supported.
> - Hardware reset via the reset controller framework, falling back to
>   the RESET command when no reset controller is present.

LGTM now,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>

...

> +	/*
> +	 * Datasheet: td(RSSTA), the delay from the RESET rising edge to the
> +	 * first I2C START, is 100ns minimum.

This is order of magnitude delay. Do you mean 100 µs? (Actually would be good to
use Greek letter in the units, looks much cleaner in the comments.)

> +	 */
> +	fsleep(1 * USEC_PER_MSEC);

Otherwise this should be simply 1 (no multiplier).

-- 
With Best Regards,
Andy Shevchenko