Re: [PATCH v4 13/15] rtc: rzn1: Add OF match data to gate SUBU register access
From: Lad, Prabhakar
Date: Fri Aug 21 2026 - 07:06:37 EST
Hi Wolfram,
On Fri, Aug 21, 2026 at 10:34 AM Wolfram Sang
<wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote:
>
>
> > } else if (!data->has_subu) {
> > return dev_err_probe(dev, -EOPNOTSUPP,
> > "No valid XTAL provided and SUBU mode not
>
> Yeah, looks good to me. It is maybe a bit hidden that xtal == NULL in
> the above case. I wonder if adding a comment above the return command
>
> /* xtal is NULL here */
>
> will help understanding? But I'll leave it to you.
>
Sure, I will add a comment.
Cheers,
Prabhakar