Re: [PATCH] staging: greybus: bootrom: fix potential NULL dereference
From: hanzhijian
Date: Fri Aug 21 2026 - 08:10:08 EST
On Fri, Aug 21, 2026 at 02:53:13PM +0300, Dan Carpenter wrote:
> You're using the word "potential" but the commit message correctly
> explains why a NULL dereference is impossible. Don't say potentially
> for things which are impossible.
>
> A lot of people would argue that the original code is easy to follow...
> It's not really fragile either...
You're right on all counts. The commit message contradicts itself, and
the refactor does make the error path harder to follow than the original
if/else. I'll drop this patch.
Thanks for the review.
hanzhijian