Re: [PATCH 32/45] clk: socfpga: Make sure clk_init_data is fully initialized

From: Dinh Nguyen

Date: Fri Aug 21 2026 - 09:31:21 EST




On 8/21/26 03:53, Geert Uytterhoeven wrote:
The clk_init_data structure contains several mutually-exclusive members
for different methods to specify the possible parents of a clock,
prompting drivers to initialize only the members they need. However,
not initializing all members may cause subtle issues, which are only
exposed when CONFIG_INIT_STACK_ALL_PATTERN or CONFIG_INIT_STACK_NONE is
enabled.

Make sure all members are fully initialized, to avoid such bugs, and to
prevent future breakage when converting drivers to a different method
for specifying the parents.

Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
---
Compile-tested only.
---
drivers/clk/socfpga/clk-gate-a10.c | 2 +-
drivers/clk/socfpga/clk-gate-s10.c | 6 +++---
drivers/clk/socfpga/clk-gate.c | 2 +-
drivers/clk/socfpga/clk-periph-a10.c | 2 +-
drivers/clk/socfpga/clk-periph-s10.c | 8 ++++----
drivers/clk/socfpga/clk-periph.c | 2 +-
drivers/clk/socfpga/clk-pll-a10.c | 2 +-
drivers/clk/socfpga/clk-pll-s10.c | 8 ++++----
drivers/clk/socfpga/clk-pll.c | 2 +-
9 files changed, 17 insertions(+), 17 deletions(-)

Acked-by: Dinh Nguyen <dinguyen@xxxxxxxxxx>

Thanks,
Dinh