Re: [PATCH v10 06/24] firmware: arm_scmi: Add basic Telemetry support

[Fayssal Benmlih]

Subject: Re: [PATCH v10 06/24] firmware: arm_scmi: Add basic Telemetry support

Hi Cristian,

Thanks for the V10 cleanup. Resetting a newly allocated DE before returning
it to the free list and unwinding partially initialized groups address two
of my V7 comments.

One resource-accounting issue appears to remain.

scmi_telemetry_de_descriptor_parse() increments num_des_tstamp after parsing
the descriptor, but iter_de_descr_process_response() registers a newly
discovered DE afterward.

If scmi_telemetry_tde_register() fails, for example because xa_insert()
fails, the DE is returned to the free list but num_des_tstamp is not
decremented. The cumulative timestamp-enabled state can then be compared
against an inflated count.

Please move the increment after successful registration, or roll it back
on every subsequent failure path.

Thanks,
Fayçal