Re: [PATCH] iio: cros_ec: Convert to DEFINE_SIMPLE_DEV_PM_OPS()
From: Jonathan Cameron
Date: Fri Aug 21 2026 - 12:04:54 EST
On Fri, 21 Aug 2026 09:10:07 +0700
Triet Hoang <triet.hoang.dev@xxxxxxxxx> wrote:
> On Fri, 21 Aug 2026 02:54:53 +0100
> Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
>
> > Hi Triet,
> >
> > Wrap to 75 ish chars for commit messages.
>
> Thanks for that! I will keep in my mind.
>
> > > Take a look at where this macro and the comment right next to it...
> >
> > > EXPORT_SYMBOL_GPL(cros_ec_sensors_pm_ops);
> > relating to this circumstance.
>
> I think we should use EXPORT_GPL_SIMPLE_DEV_PM_OPS here.
> Should I send the v2 patch to correct it?
Please do. Though normal process is to wait a few more days
first to see if you get any other feedback that can be incorporated
into v2.
Jonathan
>
> Regards,
> Triet