Re: [PATCH 10/15] dt-bindings: clock: qcom: Add Kuno Global Clock Controller

[Hardeep Sharma]

On 8/13/2026 3:10 PM, Krzysztof Kozlowski wrote:
> On Sun, Aug 09, 2026 at 12:57:09PM +0530, Hardeep Sharma wrote:
> > Add the device tree binding and clock/reset IDs for the global clock
> > controller (GCC) on the Qualcomm Kuno SoC so its device trees can
> > describe the GCC block and reference the clocks and resets it provides.
> Almost each of your bindings commit has different style. I would assume
> this you would write once and copy-paste.

Thanks for review.

Corrected in v3 : 
https://lore.kernel.org/all/20260821-kuno-soc-support-v3-0-196e2b306368@xxxxxxxxxxxxxxxx/

Best Wishes

Hardeep Sharma

> > Signed-off-by: Hardeep Sharma <hardeep.sharma@xxxxxxxxxxxxxxxx>
> > ---
> >   .../devicetree/bindings/clock/qcom,kuno-gcc.yaml   | 56 +++++++++++++
> >   include/dt-bindings/clock/qcom,kuno-gcc.h          | 95 ++++++++++++++++++++++
> >   2 files changed, 151 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/clock/qcom,kuno-gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,kuno-gcc.yaml
> > new file mode 100644
> > index 000000000000..ff01ff31c2e2
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/clock/qcom,kuno-gcc.yaml
> > @@ -0,0 +1,56 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/clock/qcom,kuno-gcc.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Qualcomm Global Clock & Reset Controller on Kuno
> > +
> > +maintainers:
> > +  - Hardeep Sharma <hardeep.sharma@xxxxxxxxxxxxxxxx>
> > +
> > +description: |
> > +  Qualcomm global clock control module provides the clocks and resets on Kuno.
> > +
> > +  See also: include/dt-bindings/clock/qcom,kuno-gcc.h
> > +
> > +properties:
> > +  compatible:
> > +    const: qcom,kuno-gcc
> > +
> > +  clocks:
> > +    items:
> > +      - description: Board XO source
> > +      - description: Board active-only XO source
> > +      - description: Sleep clock source
> > +      - description: PCIe pipe clock source
> > +
> > +  power-domains:
> > +    items:
> > +      - description: CX domain
> > +
> > +required:
> > +  - compatible
> > +  - clocks
> Not a power domain provider? Then it should not be allowed or explain
> oddities in the commit msg.

Thanks for review.

Apologies.
The GCC does host GDSCs, so it genuinely is a power-domain provider.
Rather than disallowing #power-domain-cells, in v3 I've made it
"required" in qcom,kuno-gcc.yaml and declared #power-domain-cells = <1>
on the SoC gcc node, following qcom,sdx75-gcc.

v3: 
https://lore.kernel.org/all/20260821-kuno-soc-support-v3-0-196e2b306368@xxxxxxxxxxxxxxxx/

Best Wishes

Hardeep Sharma

> > +
> > +allOf:
> > +  - $ref: qcom,gcc.yaml#
> > +
> > +unevaluatedProperties: false
> Best regards,
> Krzysztof