Re: [PATCH] phy: qualcomm: qmp-combo: update DP PHY PLL programming on Glymur

[Jason Pettit]

On Tue, Jul 21, 2026 at 10:48:33AM +0530, Nabige Aala wrote:
> +#include "phy-qcom-qmp-dp-qserdes-com-v8.h"

That filename does not match the one accepted upstream. In Linus' tree the
header is

  drivers/phy/qualcomm/phy-qcom-qmp-qserdes-dp-com-v8.h

The "dp" and "qserdes" components are transposed. As written the build stops
at the include.

  drivers/phy/qualcomm/phy-qcom-qmp-combo.c:56:10: fatal error:
    phy-qcom-qmp-dp-qserdes-com-v8.h: No such file or directory

Dropping the line instead is not a fix, because the patch uses two symbols the
header supplies.

  phy-qcom-qmp-combo.c:321: error: 'DP_QSERDES_V8_COM_C_READY_STATUS' undeclared
  phy-qcom-qmp-combo.c:322: error: 'DP_QSERDES_V8_COM_CMN_STATUS' undeclared

Both are defined in phy-qcom-qmp-qserdes-dp-com-v8.h, which has been present in
mainline since v7.0-rc1. Correcting the spelling is the only change needed. With
that one edit the patch builds cleanly for me on next-20260821.

One other thing for the respin. The patch no longer applies with a plain git am
on current linux-next. The include block gained a line in

  eca0e717aab1 ("phy: qualcomm: qmp-combo: Add support for Hawi SoC")

so the context of the first hunk no longer matches. git am -3 applies it.

One process note. The subject line reads [PATCH], but the changelog in this
message reads "Changes in v2". The revision is therefore invisible to b4, to
patchwork, and to anyone following the thread. When you split this into the
smaller commits Dmitry asked for, please post the result as

  [PATCH v3 0/3]

rather than starting the numbering again from [PATCH]. That keeps the lineage
traceable from v1 through the split series.

I am carrying this patch as a prerequisite for HP EliteBook X G2q board support,
so I am happy to test a v2 on Glymur hardware.

Thanks,
Jason