Re: [PATCH 3/3] iio: gyro: adis16136: fix unprotected debugfs reads
From: Jonathan Cameron
Date: Sat Aug 22 2026 - 17:39:37 EST
On Sat, 15 Aug 2026 11:49:12 +0300
Andy Shevchenko <andriy.shevchenko@xxxxxxxxx> wrote:
> On Fri, Aug 14, 2026 at 06:07:28PM +0900, Arka Mondal wrote:
> > The serial_number file operations are open coded and never call
> > debugfs_file_get(), which debugfs_create_file_unsafe() requires.
> > debugfs_remove_recursive() therefore does not wait for a read in
> > progress, and unbind frees the iio_dev underneath it.
> >
> > Use debugfs_create_file() instead.
>
> Same question as per patch 1.
> But if Jonathan likes as is
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
>
I haven't looked into the tradeoffs fo the two possible solutions,
so would like v2 to have a cover letter and for that to state why
one was chosen over the other.
Thanks
Jonathan