Re: [PATCH v2] iio: admv1013: initialize callback mutex before registering notifier

[Jonathan Cameron]

On Wed, 19 Aug 2026 22:17:51 +0800
Runyu Xiao <runyu.xiao@xxxxxxxxxx> wrote:

> admv1013_probe() registers a clock notifier whose callback takes st->lock
> on POST_RATE_CHANGE. Initialize the mutex before
> devm_clk_notifier_register() so the callback cannot observe an
> uninitialized lock during probe.
> 
> Use devm_mutex_init() so the lock lifetime is tied to the device and
> cleanup stays paired with the rest of the managed probe resources.
> 
> Fixes: da35a7b526d9 ("iio: frequency: admv1013: add support for ADMV1013")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Runyu Xiao <runyu.xiao@xxxxxxxxxx>

The code has changed a bit, so what I applied to the fixes-togreg branch of
iio.git ended up as:

diff --git a/drivers/iio/frequency/admv1013.c b/drivers/iio/frequency/admv10
index b852378b3f68..e86b59bf23fd 100644                                     
--- a/drivers/iio/frequency/admv1013.c                                      
+++ b/drivers/iio/frequency/admv1013.c                                      
@@ -602,11 +602,14 @@ static int admv1013_probe(struct spi_device *spi)     
                                     "failed to get the LO input clock\n"); 

        st->nb.notifier_call = admv1013_freq_change;
-       ret = devm_clk_notifier_register(dev, st->clkin, &st->nb);          
+                                                                           
+       ret = devm_mutex_init(dev, &st->lock);                              
        if (ret)
                return ret;

-       mutex_init(&st->lock);                                              
+       ret = devm_clk_notifier_register(dev, st->clkin, &st->nb);          
+       if (ret)                                                            
+               return ret;                                                 

        ret = admv1013_init(st, vcm_uv);
        if (ret)


It will need a manual backport as a result if we want this to
go to stable.

Note it wasn't a particularly recent change. Make sure your patches
apply on linux-next or the appropriate subsystem tree.

Also, please don't reply to an earlier version when sending an
updated one.  It didn't matter here but for more complex threads
they can become very hard to follow + your email ends up way
back in people's email history so may not get much review.

Thanks

Jonathan

> ---
>  drivers/iio/frequency/admv1013.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/frequency/admv1013.c b/drivers/iio/frequency/admv1013.c
> index d8e8d541990f..ff599b5c88ef 100644
> --- a/drivers/iio/frequency/admv1013.c
> +++ b/drivers/iio/frequency/admv1013.c
> @@ -594,11 +594,13 @@ static int admv1013_probe(struct spi_device *spi)
>  				     "failed to get the LO input clock\n");
>  
>  	st->nb.notifier_call = admv1013_freq_change;
> -	ret = devm_clk_notifier_register(&spi->dev, st->clkin, &st->nb);
> +	ret = devm_mutex_init(&spi->dev, &st->lock);
>  	if (ret)
>  		return ret;
>  
> -	mutex_init(&st->lock);
> +	ret = devm_clk_notifier_register(&spi->dev, st->clkin, &st->nb);
> +	if (ret)
> +		return ret;
>  
>  	ret = admv1013_init(st, vcm_uv);
>  	if (ret) {