Re: [PATCH] powerpc: remove dead 440SP code

[Julian Braha]

Hi Christophe,

On 8/17/26 07:29, Christophe Leroy (CS GROUP) wrote:
> 
> 
> Le 16/08/2026 à 14:56, Julian Braha a écrit :
>> The 440SP config option can never be enabled, making all references to it
>> dead code.
>>
>> Let's remove support for 440SP, since nobody can be using it anyway.
>>
>> This dead code was found by kconfirm, a static analysis tool for Kconfig.
> 
> It would be good to include history in the commit description:
> 
> As far as I can see, users of CONFIG_440SP were commented out by commit
> f65573314e4e ("[POWERPC] Re-organize Kconfig code for 4xx in arch/
> powerpc") and removed by commit ff5f483f3091 ("powerpc: 4xx: remove
> commented out Kconfig entries")
> 
> 
>>
>> Signed-off-by: Julian Braha <julianbraha@xxxxxxxxx>
>> ---
>>   arch/powerpc/boot/cuboot-katmai.c   |  2 +-
>>   arch/powerpc/include/asm/async_tx.h |  2 +-
>>   arch/powerpc/include/asm/dcr-regs.h | 10 +++++-----
>>   arch/powerpc/kernel/cpu_specs_44x.h | 12 ------------
>>   arch/powerpc/platforms/44x/Kconfig  |  3 ---
>>   drivers/dma/Kconfig                 |  2 +-
>>   drivers/dma/ppc4xx/adma.c           |  9 ---------
>>   drivers/dma/ppc4xx/adma.h           |  2 +-
>>   drivers/dma/ppc4xx/dma.h            |  9 ---------
>>   drivers/net/ethernet/ibm/emac/mal.h |  2 +-
>>   10 files changed, 10 insertions(+), 43 deletions(-)
>>
>> diff --git a/arch/powerpc/boot/cuboot-katmai.c b/arch/powerpc/boot/
>> cuboot-katmai.c
>> index 034a748fde24..fcd71e76309f 100644
>> --- a/arch/powerpc/boot/cuboot-katmai.c
>> +++ b/arch/powerpc/boot/cuboot-katmai.c
>> @@ -31,7 +31,7 @@ static void katmai_fixups(void)
>>   {
>>       unsigned long sysclk = 33333000;
>>   -    /* 440SP Clock logic is all but identical to 440GX
>> +    /* 440SPe Clock logic is all but identical to 440GX
>>        * so we just use that code for now at least
>>        */
>>       ibm440spe_fixup_clocks(sysclk, 6 * 1843200, 0);
>> diff --git a/arch/powerpc/include/asm/async_tx.h b/arch/powerpc/
>> include/asm/async_tx.h
>> index a14758426dd5..1ff5b2ca3ed1 100644
>> --- a/arch/powerpc/include/asm/async_tx.h
>> +++ b/arch/powerpc/include/asm/async_tx.h
>> @@ -7,7 +7,7 @@
>>   #ifndef _ASM_POWERPC_ASYNC_TX_H_
>>   #define _ASM_POWERPC_ASYNC_TX_H_
>>   -#if defined(CONFIG_440SPe) || defined(CONFIG_440SP)
>> +#if defined(CONFIG_440SPe)
> 
> Replace by #ifdef CONFIG_440SPe

Thanks for your feedback, will send a v2!

- Julian Braha